Add support for Debian 13 (trixie) #1638
Conversation
trefzer
requested review from
a team,
SimonHoenscheid,
alexjfisher,
bastelfreak,
deric,
ekohl and
smortex
as code owners
|
Works for me, thanks! |
smortex
changed the title
| --- | ||
| # Defaults for Debian Bullseye (11) | ||
|
|
||
| postgresql::globals::python_package_name: 'python3-psycopg2' |
There was a problem hiding this comment.
This change broke the tests. And I don't know why a Debian 11 change is in the Debian 13 PR. The default for Debian 11 is set at https://github.com/puppetlabs/puppetlabs-postgresql/blob/main/manifests/params.pp#L97 . But that default seems to be wrong, because the actual package name is python3-psycopg2 ? See https://packages.debian.org/search?suite=bullseye&searchon=names&keywords=python3-psycopg2
- So the code in the module for debian 11 was wrong for years?
- This change fixed the code, but in the wrong place
- it broke the tests, they still use the old name
- this change doesn't relate to adding debian 13 support?
- 9d4fc30 introduced the ubuntu/debian switch in params.pp, but the debian 11 package name was already wrong
- tests for python-psycopg2 were added in 03b3df3, without debian version specific tests
- Debian 11 was added in pdksync - (IAC-1709) - Add Support for Debian 11 #1288 without adjusting tests
- https://github.com/puppetlabs/puppetlabs-postgresql/pull/1311/files#diff-8e105ecad7dcaa2453c2cf6679853043c9fdccf84eb7b921bc8233ab789cab3f added the Debian 11 tests, but already with the wrong package name
I think the issue here is that Debian 11 was added to metadata.json without proper (acceptance) tests and nobody used the python extension, so people didn't notice it.
There was a problem hiding this comment.
So the code in the module for debian 11 was wrong for years?
It appears that way. In #1557 (comment) I wonder why I stated that there as a python-psycopg2 for Debian 11.
This change fixed the code, but in the wrong place
Correct. Including this here is weird: it negates the code we have for it:
puppetlabs-postgresql/manifests/params.pp
Lines 166 to 170 in b85be45
And then all your other observations are also correct.
6 participants
add support for the upcoming debian trixie release.